[a11y] Fix missing aria-label in pagenavigation#43600
Merged
MacJoom merged 5 commits intojoomla:4.4-devfrom Jun 14, 2024
Merged
[a11y] Fix missing aria-label in pagenavigation#43600MacJoom merged 5 commits intojoomla:4.4-devfrom
MacJoom merged 5 commits intojoomla:4.4-devfrom
Conversation
brianteeman
reviewed
Jun 2, 2024
Co-authored-by: Brian Teeman <brian@teeman.net>
Contributor
|
I have tested this item ✅ successfully on aab5d65 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43600. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on aab5d65 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43600. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43600. |
Contributor
|
Thank you! |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Aug 22, 2024
Kostelano
added a commit
to Joomla-Ukraine/uk-UA
that referenced
this pull request
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The <nav in pagenavigation needs an aria-label.
Testing Instructions
You need a site where you have a pageanavigation.
Inspect the sourceode before and after patch
Actual result BEFORE applying this Pull Request
No aria-label for the <nav element
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed